[libseccomp-discuss] [PATCH] configure.ac: Only add 'serial-tests' for automake >= 1.12.

[Markos Chandras]

From: Vicente Olivert Riera <***@imgtec.com>

This patch is based on the following patch written by Richard W.M. Jones
from RedHat:

https://www.redhat.com/archives/libguestfs/2013-February/msg00102.html

Earlier versions of automake complain if they get a configuration
parameter which they don't understand. The error is:

configure.ac:27: error: option 'serial-tests' not recognized

Use some m4 hackery to work around this.

Signed-off-by: Vicente Olivert Riera <***@imgtec.com>
Signed-off-by: Markos Chandras <***@imgtec.com>
---
configure.ac | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 59044e6ff14a..26daeb60b15c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,7 +31,20 @@ AC_CONFIG_MACRO_DIR([m4])
dnl ####
dnl automake configuration
dnl ####
-AM_INIT_AUTOMAKE([-Wall foreign subdir-objects tar-pax serial-tests])
+dnl Initialize automake. automake < 1.12 didn't have serial-tests and
+dnl gives an error if it sees this, but for automake >= 1.13
+dnl serial-tests is required so we have to include it. Solution is to
+dnl test for the version of automake (by running an external command)
+dnl and provide it if necessary. Note we have to do this entirely using
+dnl m4 macros since automake queries this macro by running
+dnl 'autoconf --trace ...'.
+m4_define([serial_tests], [
+ m4_esyscmd([automake --version |
+ head -1 |
+ awk '{split ($NF,a,"."); if (a[1] == 1 && a[2] >= 12) { print "serial-tests" }}'
+ ])
+])
+AM_INIT_AUTOMAKE(-Wall foreign subdir-objects tar-pax serial_tests) dnl NB: Do not [quote] this parameter.

dnl ####
dnl build tools

[Paul Moore]

Post by Markos Chandras
This patch is based on the following patch written by Richard W.M. Jones
https://www.redhat.com/archives/libguestfs/2013-February/msg00102.html
Earlier versions of automake complain if they get a configuration
configure.ac:27: error: option 'serial-tests' not recognized
Use some m4 hackery to work around this.
---
configure.ac | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)

Thanks, applied with some minor style tweaks to the comments.

Post by Markos Chandras
diff --git a/configure.ac b/configure.ac
index 59044e6ff14a..26daeb60b15c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,7 +31,20 @@ AC_CONFIG_MACRO_DIR([m4])
dnl ####
dnl automake configuration
dnl ####
-AM_INIT_AUTOMAKE([-Wall foreign subdir-objects tar-pax serial-tests])
+dnl Initialize automake. automake < 1.12 didn't have serial-tests and
+dnl gives an error if it sees this, but for automake >= 1.13
+dnl serial-tests is required so we have to include it. Solution is to
+dnl test for the version of automake (by running an external command)
+dnl and provide it if necessary. Note we have to do this entirely using
+dnl m4 macros since automake queries this macro by running
+dnl 'autoconf --trace ...'.
+m4_define([serial_tests], [
+ m4_esyscmd([automake --version |
+ head -1 |
+ awk '{split ($NF,a,"."); if (a[1] == 1 && a[2] >= 12) {
print "serial-tests" }}' + ])
+])
Do not [quote] this parameter.
dnl ####
dnl build tools